test(core): Improve offline transport test performance #13460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch to fake timers
Lms24
commented
Aug 26, 2024
| @@ -411,7 +416,7 @@ describe('makeOfflineTransport', () => { | |||
| START_DELAY + 2_000, | |||
| ); | |||
|
|
|||
| it.skip( | |||
| it( | |||
There was a problem hiding this comment.
We previously skipped this test because it was flaky. I'm gonna un-skip it for now. Maybe using fake timers and or vitest helps. If we notice it being flaky, we should fix the test this time
|
@timfish would you mind giving this PR a quick review - I think you wrote the tests initially, right? |
timfish
approved these changes
Aug 26, 2024
|
Argh I tried converting this to jest after giving up on switching to vitest (#13458). Turns out jest fake timers work differently and I couldn't get the tests passing after making the switch. I don't have the time to revisit so I'm gonna close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #13439
based on #13458
This PR significantly improves the performance of our offline transport unit tests. These tests were the bottleneck of our unit test performance previously, as they included actual multi-second timeouts. This PR converts the test to use vitest's fake timers which as far as I can tell, still tests the offline transport correctly but heavily increases performance.
Locally, I this brought down the runtime of the entire test suite from ~20s to ~6s.